[VL] Customize VCPKG build features according to user's build options #7052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
PHILO-HE
force-pushed
the
control-vcpkg-features
branch
from
749c594 to
a938b8f
Compare
PHILO-HE
force-pushed
the
control-vcpkg-features
branch
from
0d8a702 to
8006034
Compare
rui-mo
approved these changes
Sep 23, 2024
| export VCPKG_TRIPLET_INSTALL_DIR=${SCRIPT_ROOT}/vcpkg_installed/${VCPKG_TRIPLET} | ||
| export EXPORT_TOOLS_PATH="${VCPKG_TRIPLET_INSTALL_DIR}/tools/protobuf" | ||
|
|
||
| if [ "\${GLUTEN_VCPKG_ENABLED:-}" != "${VCPKG_ROOT}" ]; then |
There was a problem hiding this comment.
"\${GLUTEN_VCPKG_ENABLED:-}" or "${GLUTEN_VCPKG_ENABLED:-}"?
| export VCPKG_TRIPLET=${VCPKG_TRIPLET} | ||
|
|
||
| export CMAKE_TOOLCHAIN_FILE=${SCRIPT_ROOT}/toolchain.cmake | ||
| export PKG_CONFIG_PATH=${VCPKG_TRIPLET_INSTALL_DIR}/lib/pkgconfig:${VCPKG_TRIPLET_INSTALL_DIR}/share/pkgconfig:\${PKG_CONFIG_PATH:-} |
There was a problem hiding this comment.
\${PKG_CONFIG_PATH:-} vs ${PKG_CONFIG_PATH:-}?
Comment on lines
+10
to
11
| init_vcpkg_env=$("${SCRIPT_ROOT}/init.sh" $@) | ||
| eval "$init_vcpkg_env" |
There was a problem hiding this comment.
Do we still need this eval?
|
The change breaks one of my daily benchmark jobs. Relevant log: https://gist.github.com/zhztheplayer/f3f4d946d42060694c743f32ab38ba7b |
zhztheplayer
added a commit
to zhztheplayer/gluten
that referenced
this pull request
Sep 23, 2024
zhztheplayer
added a commit
that referenced
this pull request
Sep 24, 2024
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
sharkdtu
pushed a commit
to sharkdtu/gluten
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When vcpkg is enabled, installing native dependencies related to test, hdfs, s3, gcs and abfs should be optional, which depends on user-specified build options. We can put always-required dependencies as vcpkg default feature and enable other feature according to build option.
How was this patch tested?
CI.